Skip to content

feat: added get_package_license to module creation - #56

Merged
eliocamp merged 4 commits into
eliocamp:mainfrom
munoztd0:main
Nov 13, 2026
Merged

eliocamp merged 4 commits into
eliocamp:mainfrom
munoztd0:main

Conversation

@munoztd0

@munoztd0 munoztd0 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

fix: #50
Tested with Matrix
Screenshot From 2026-09-03 15-01-16

@eliocamp eliocamp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good overall. I just have a couple of questions for the case when the get_package_license fails.

Comment thread R/module-create.R Resolved
@munoztd0
munoztd0 requested a review from eliocamp September 6, 2026 16:23

@eliocamp eliocamp left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. I am not sure if "Inherit from source package" or "Not Specified" are valid licences, but in principle that's not too bad since then a CMD check will flag this and force the developer to look at the licence in detail.

@eliocamp
eliocamp merged commit 3c850d2 into eliocamp:main Nov 13, 2026
@munoztd0

Copy link
Copy Markdown
Contributor Author

This looks good now. I am not sure if "Inherit from source package" or "Not Specified" are valid licences, but in principle that's not too bad since then a CMD check will flag this and force the developer to look at the licence in detail.

That's was the idea indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License for translation modules

2 participants