Repository navigation
feat: added get_package_license to module creation - #56
Merged
Merged
Conversation
eliocamp
reviewed
Sep 4, 2026
eliocamp
left a comment
Owner
There was a problem hiding this comment.
Thanks! It looks good overall. I just have a couple of questions for the case when the get_package_license fails.
eliocamp
reviewed
Nov 13, 2026
eliocamp
left a comment
Owner
There was a problem hiding this comment.
This looks good now. I am not sure if "Inherit from source package" or "Not Specified" are valid licences, but in principle that's not too bad since then a CMD check will flag this and force the developer to look at the licence in detail.
Contributor
Author
That's was the idea indeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #50

Tested with Matrix